Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality comparer doesn't compare base types #55

Open
ghost opened this issue Oct 17, 2018 · 0 comments
Open

Equality comparer doesn't compare base types #55

ghost opened this issue Oct 17, 2018 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 17, 2018

If a generated class has a BaseTypeHint, the generate equality comparer compares only the derived type's properties. It doesn't delegate to the base type's equality comparer to compare the base type's properties.

The nature of the base class comparison must depend on the ComparisonKind of the base class. Unfortunately, as the code stands, ComparisonKind is a property of the PropertyInfo class; that is, the code generator understands how to compare property values, but only because it understands the schema that describes the property. There is nothing that represents the ComparisonKind of a class. I'll need to add that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants