Change to use Mach exception handler by default #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #637 +/- ##
===========================================
- Coverage 92.9% 92.85% -0.05%
===========================================
Files 207 207
Lines 14508 14510 +2
Branches 841 841
===========================================
- Hits 13478 13473 -5
- Misses 1017 1024 +7
Partials 13 13
Continue to review full report at Codecov.
|
iamclement
suggested changes
Jun 22, 2017
| * The SDK will not check if the app is running in an AppStore environment or if a debugger is attached because some | ||
| * developers chose to do both at their own risk. | ||
| * `[MSCrashes disableMachExceptionHandler]`; | ||
| * `[MSMobileCenter start:@"YOUR_APP+_ID" withServices:@[[MSCrashes class]]];` |
There was a problem hiding this comment.
"YOUR_APP_ID", a + sign sneaked into it ^^.
| * `[MSCrashes enableMachExceptionHandler]`; | ||
| * `[MSMobileCenter start:@"YOUR_APP+_ID" withServices:@[[MSCrashes class]]];` | ||
| * `MSCrashes.disableMachExceptionHandler()` | ||
| * `MSMobileCenter.start("YOUR_APP+_ID", withServices: [MSAnalytics.self, MSCrashes.self])` |
There was a problem hiding this comment.
Same thing here: "YOUR_APP_ID".
iamclement
approved these changes
Jun 23, 2017
ElektrojungeAtWork
approved these changes
Jun 26, 2017
|
Good point @TroubleMakerBen. I also updated the version. |
ElektrojungeAtWork
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be a separate doc PR in doc repo.