Make sure to deactivate log discaring while reenabling #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #639 +/- ##
===========================================
+ Coverage 92.9% 93.15% +0.25%
===========================================
Files 207 207
Lines 14508 14563 +55
Branches 841 844 +3
===========================================
+ Hits 13478 13566 +88
+ Misses 1017 994 -23
+ Partials 13 3 -10
Continue to review full report at Codecov.
|
jaeklim
suggested changes
Jun 22, 2017
| @@ -278,6 +278,10 @@ - (void)setEnabled:(BOOL)isEnabled andDeleteDataOnDisabled:(BOOL)deleteData { | |||
|
|
|||
| // Prevent further logs from being persisted. | |||
| self.discardLogs = YES; | |||
| }else { | |||
| id mockLog = [self getValidMockLog]; | ||
| OCMReject([self.storageMock saveLog:[OCMArg any] withGroupId:[OCMArg any]]); | ||
|
|
||
| /** |
There was a problem hiding this comment.
Use the same comment style.
| [self enqueueChannelEndJobExpectation]; | ||
| }]; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Use the same comment style.
jaeklim
approved these changes
Jun 23, 2017
iamclement
deleted the
fix/reenabling-deactivate-log-discarding-everytime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.