This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Fix conversion code from MarkedString to IMarkdownString in hovers #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion code for hovers ignored MarkedString's `language` property which caused the content to be rendered incorrectly. The code has been corrected to honour the property and now creates the code block correctly. Signed-off-by: Remy Suen <remy.suen@gmail.com>
|
👍 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion code for hovers ignored
MarkedString'slangageproperty. It was incorrectly referencing itsvalueproperty and caused the content to be rendered in a strange way. The code has been fixed to use thelanguageproperty and now creates the code block correctly.The problem can be reproduced and the fix verified with the
test/index.htmltest page by hovering over stuff like.float-lefton line 38 or.highlighton line 46.See microsoft/monaco-editor#805.