Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sideEffects false for tree-shaking in webpack #981

Merged
merged 1 commit into from
Aug 10, 2018
Merged

add sideEffects false for tree-shaking in webpack #981

merged 1 commit into from
Aug 10, 2018

Conversation

mscolnick
Copy link
Contributor

No description provided.

@alexdima alexdima merged commit 5e178f8 into microsoft:master Aug 10, 2018
@alexdima alexdima added this to the July 2018 milestone Aug 10, 2018
@alexdima
Copy link
Member

alexdima commented Aug 13, 2018

I had to revert this, because it led to all the CSS imports being ignored...

@mscolnick
Copy link
Contributor Author

ah ok, sorry about that. the change should've been this:

  "sideEffects": [
    "*.css"
  ],

still ok if i submit the PR?

@alexdima
Copy link
Member

Sure, but can you please test the following before:

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants