Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

[clojure] Improve Clojure syntax highlighting. #45

Merged
merged 5 commits into from
Sep 13, 2018

Conversation

finalfantasia
Copy link
Contributor

@finalfantasia finalfantasia commented Sep 12, 2018

This PR:

  • Updates the keyword list with public symbols from clojure.core for Clojure 1.9.
  • Improves syntax highlighting of symbols, strings, character literals, and number literals.
  • Adds rules for syntax highlighting Clojure keywords and reader macro characters.
  • Fixes an issue where forms following a single semicolon (;) are not marked as comment.
  • Fixes an issue where parts of multi-line strings were not correctly syntax highlighted.
  • Adds additional test coverage for tokenization code.
  • Adds support for (comment ...) form.

Abdussalam Abdurrahman added 3 commits September 11, 2018 11:37
This commit:
- Updates the keyword list with public symbols from `clojure.core` for
Clojure 1.9.
- Improves syntax highlighting of symbols, strings, character literals,
and number literals.
- Adds rules for syntax highlighting Clojure keywords and reader macro
characters.
- Fixes an issue where forms following a single semicolon (`;`) are not
marked as comments.
- Fixes an issue where parts of multi-line strings were not correctly
syntax highlighted.
- Adds additional test coverage for tokenization code.
@msftclas
Copy link

msftclas commented Sep 12, 2018

CLA assistant check
All CLA requirements met.

@finalfantasia
Copy link
Contributor Author

Here are some "before" and "after" screenshots:

Before
symbols_before

After
symbols_after

Before
game_of_life_before

After
game_of_life_after

Abdussalam Abdurrahman added 2 commits September 11, 2018 21:41
@alexdima
Copy link
Member

👍 Great! Thank you!

@alexdima alexdima merged commit 0aea831 into microsoft:master Sep 13, 2018
@alexdima alexdima added this to the October 2018 milestone Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants