[RN 0.50] Version doesn't get pushed, ls: "No installs recorded" #1072
Comments
|
This probably facebook/react-native#16689 |
|
Metro Bundler fails again, probably. |
|
Update: Got another Sentry error a few hours ago: https://sentry.io/share/issue/1d0884bb8de44f3998ff8e1fe32aa23c/ I just updated RN from 0.50.1 to 0.50.2, and added this to my This seems to have done the trick, with a new CodePush and restarting my app: Commenting upstream on what appears to be a fix. Thanks for the reference @adbl |
|
Re-opening this as I'm again seeing similar "No installs recorded" on pushed version, after running Previously 5.2.0-beta, upgrading to 5.2.1. On 5.2.0-beta, pushed versions get deployed as reported by |
fungilation
changed the title
|
@fungilation please double check this is not metro-bundler/RN issue as it was before. |
|
I'm pretty certain it's not, as strictly in terms of change management, I haven't touched RN itself with this change. And Metro related issues have been fixed in RN 0.50. Before: RN-code-push 5.2.0-beta, versions pushed and verified as deployed based on After: RN-code-push 5.2.1, versions pushed not deployed. Same RN. |
|
@fungilation could you please provide minimal version of your app so we could try to reproduce your issue? Please attach app logs too if you have it. |
|
I'm not sure how I can quickly provide a minimal but still functional version of my app. How about an ejected skeleton from CRNA with my {
"name": "APP",
"version": "0.0.1",
"private": true,
"eslintConfig": {
"parserOptions": {
"ecmaVersion": 6,
"sourceType": "module",
"ecmaFeatures": {
"jsx": true,
"experimentalObjectRestSpread": true
}
},
"env": {
"browser": true,
"node": true
},
"plugins": [
"react",
"react-native"
],
"rules": {
"comma-dangle": [
2,
"always-multiline"
],
"semi": [
2,
"never"
],
"react-native/no-unused-styles": 2,
"react-native/split-platform-components": 2
}
},
"scripts": {
"start": "node node_modules/react-native/local-cli/cli.js start"
},
"dependencies": {
"babel-plugin-idx": "^2",
"he": "^1.1.0",
"lodash": "^4.17.2",
"moment": "^2.19.0",
"moment-timezone": "^0.5.10",
"node-summary": "../node-summary",
"react": "16.0.0",
"react-native": "0.50.4",
"react-native-blur": "^3.2.0",
"react-native-code-push": "5.2.0-beta",
"react-native-firebase": "^3.0",
"react-native-fit-image": "^1.4.8",
"react-native-highlight-words": "smartkarma/react-native-highlight-words",
"react-native-keep-awake": "^2.0.6",
"react-native-linear-gradient": "^2.0.0",
"react-native-modalbox": "^1.3.8",
"react-native-notification": "../react-native-notification",
"react-native-orientation": "^3.0.0",
"react-native-parallax-scroll-view": "../react-native-parallax-scroll-view",
"react-native-safari-view": "^2.0.0",
"react-native-sentry": "^0.31",
"react-native-sha256": "^1.1.1",
"react-native-status-bar-size": "^0.3.2",
"react-native-swiper": "^1.5.10",
"react-native-tooltip": "../react-native-tooltip",
"react-native-tts": "^1.3.0",
"react-native-vector-icons": "^4.1.1",
"react-native-webview-bridge": "../react-native-webview-bridge-RN0.40",
"react-redux": "^5.0.1",
"redux": "^3.6.0",
"redux-thunk": "^2.1.0"
},
"devDependencies": {
"redux-logger": "^3.0.6"
},
"resolutions": {
"moment-timezone/moment": "^2.19.0"
}
} |
|
Update: Upgraded RN to 0.51.0 and tested a deploy. I'm at a loss what broke code push with my install, and if it is specific to my install, how I would fix it. I'd try Or is this more systemic, if there's any other reports of deploy breakage while CodePush is being folded into App Center? Suggestion appreciated on how I can "reset" my install or otherwise test why ls keeps showing "No installs recorded" from CodePush server? |
|
Tried Also tried deleting whole /node_modules/ directory and reinstall with How do I do a complete unlink/uninstall and clean reinstall that may solve this linking issue? I want to see whether |
|
Tried debuging as per the doc, with And that's all it tells me, no logs show up at all after the "Listening for" line, while my app is running in iOS (11.2) Simulator. My CodePush integration code in class APP extends Component {
...
}
APP = codePush({
checkFrequency: codePush.CheckFrequency.ON_APP_RESUME,
installMode: codePush.InstallMode.ON_NEXT_SUSPEND,
// installMode: codePush.InstallMode.ON_NEXT_RESUME,
minimumBackgroundDuration: 600, // code-push deployment ls APP > Install Metrics should show N pending. To be installed after N seconds
})(APP)
Sentry.config("DSN").install()
// https://docs.sentry.io/clients/react-native/codepush/
codePush.getUpdateMetadata().then((update) => {
if (update)
Sentry.setVersion(update.appVersion + '-codepush:' + update.label)
})
AppRegistry.registerComponent('APP', () => APP)No logs mean that |
|
Hi @fungilation, sorry for delay, unfortunately, I have another priorities for now, but don't worry I will be back soon and we will continue discussion. |
|
@fungilation please try to re-install CodePush for your app:
|
|
Ok. Gone through every step of uninstalling and reinstalling/linking manually. Same thing. Along the way, I even found and fixed a side issue. This is in my APP = codePush({
deploymentKey: '[KEY]', // can't rely on CodePushDeploymentKey: $(CODEPUSH_KEY) in Info.plist?
checkFrequency: codePush.CheckFrequency.ON_APP_RESUME,
installMode: codePush.InstallMode.ON_NEXT_SUSPEND, // https://github.com/Microsoft/react-native-code-push/pull/770
// installMode: codePush.InstallMode.ON_NEXT_RESUME, // https://github.com/Microsoft/react-native-code-push/blob/master/docs/api-js.md#installmode
minimumBackgroundDuration: 600, // code-push deployment ls APP > Install Metrics should show N pending. To be installed after N seconds
})(APP)where I didn't specify and I have CODEPUSH_KEY as 2 variables in Xcode production and staging build configs. This was all working before. But now Chrome DevTools console attached to my app in simulator now tells me it was missing a key, so I additionally set it in BUT, hoping for the best with actual code pushed in production, with a I'm out of ideas. Anything else I can debug or test? |
|
@fungilation could you please share with me the output of |
And from https://appcenter.ms/ dashboard, deploys were working up to last version at v231 on Dec. 4, about a week ago. Please tell me my hair pulling isn't just me and this is something server-side, maybe related to migration to App Center 😭
|
|
@fungilation Its looks strange, I believe we should investigate this on our side. Yeah, probably, this issue somehow related with migration to appcenter. @fungilation could you please confirm that switching to |
|
Umm, Or did you mean: (gfung/WonderSwipe is the current app selected in So I did that. After, I rebuilt app in Xcode. Some relevant Xcode logs that has "codepush" in the lines, while my app is running on device in Production mode and attached to Xcode: Then I detached app from Xcode and restarted it. Checking |
|
@fungilation could you please add download progress logs to your app like this: sync() {
CodePush.sync(
{ /* your options */},
(progress) => {
console.log(progress.receivedBytes + " of " + progress.totalBytes + " received.")
}
);
}and share these logs with us? |
|
I think I have the same problem, after migrating to appcenter (and moving app under new organization), last thing I see in iOS log is: Using RN 51.0 and react-native-code-push: 5.2.1 |
|
@ruslan-bikkinin This is console logs I'm getting: Please check if I've integrated your code correctly, since I used to specify options in class WonderSwipe extends Component {
...
}
codePush.sync({
deploymentKey: '[KEY]', // can't rely on CodePushDeploymentKey: $(CODEPUSH_KEY) in Info.plist?
checkFrequency: codePush.CheckFrequency.ON_APP_RESUME,
installMode: codePush.InstallMode.ON_NEXT_SUSPEND, // https://github.com/Microsoft/react-native-code-push/pull/770
// installMode: codePush.InstallMode.ON_NEXT_RESUME, // https://github.com/Microsoft/react-native-code-push/blob/master/docs/api-js.md#installmode
minimumBackgroundDuration: 600, // code-push deployment ls WonderSwipe > Install Metrics should show N pending. To be installed after N seconds
},
(progress) => {
console.log("[CodePush]", progress.receivedBytes + " of " + progress.totalBytes + " received.")
}
)
WonderSwipe = codePush()(WonderSwipe) |
|
And in case you are wondering, I have in Info.plist: |
|
@ruslan-bikkinin any status update would be much appreciated, like whether you think it really is a server side issue or you need more time to investigate? I just want to decide whether I should hold off my app releases or not while CodePush is broken. Much appreciated |
|
Hi again @fungilation and sorry for the delayed response - currently we are under-resourced and have to take care of other things in terms of appcenter and codepush. As for your case, I’ve tried to reproduce it, but with no luck, so could you please share with me the minimum version of your app where the issue reproduces? (package.json is not enough due to we also need js code to reproduce the issue). You also can email me at v-rubikk@microsoft.com and share the full working version of your app so I can try to investigate it, but again - the minimum working version of you the code with minimum repro steps is the best choice for us because we’ll be able to determine the root cause of the issue much faster. I’ve also notice that you are using |
|
The issue was somehow fixed by itself for us, so latest code-push release using appcenter cli worked just fine. |
|
Hallelujah! This after upgrading other packages I have (moment, react-native-firebase, react-native-sentry), and as part of upgrades I nuked the ios/Pods directory and rebuilt it. And after rebuilding app in Xcode, it just started working with this in Xcode logs: Emphasis on the last line: Tested with deploys via both forms: Considering the timing of both @ovaris and I having pushed versions downloading/applying in our apps again today. A confirmation from Microsoft that this has been a server issue and is now fixed would be great? |
|
Hi @fungilation, @ovaris, thanks for reaching us and sorry for the inconvenience. The issue looks really weird (especially in the fact that it does not reproduce for us and that it has been resolved by itself). Also we haven't seen it before. As for now - please update your code-push-cli due to it contains a bugfix that may affect not only users who are using code-signing (this fix has not been merged for appcenter-cli yet). Probably the issue can somehow relate to this one microsoft/code-push#547 - we are working on it. Please let us know if it will happen again, so I'm closing this for now. |
Steps to Reproduce
code-push release-react [APP] ios --outputDir ../[APP]-bundle -d ProductionExpected Behavior
Pushed code version gets deployed
Actual Behavior
"No installs recorded" on pushed version, after running
code-push deployment ls [APP]and quit, restart app.$ code-push deployment ls [APP]:Environment
$ react-native info:The text was updated successfully, but these errors were encountered: