Skip to content

Commit

Permalink
chore(engineering)!: set minimum supported Node.JS version to 14
Browse files Browse the repository at this point in the history
BREAKING CHANGE: this requires using a newer Node.JS version
  • Loading branch information
joaomoreno committed Nov 4, 2021
1 parent cad0362 commit 302d33d
Show file tree
Hide file tree
Showing 10 changed files with 89 additions and 141 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [10, 12, 14, 16, 17]
node-version: [14, 16, 17]
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

## Requirements

- [Node.js](https://nodejs.org/en/) at least `10.x.x`
- [Node.js](https://nodejs.org/en/) at least `14.x.x`

Or simply [Docker](#via-docker).

Expand Down
86 changes: 17 additions & 69 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,13 @@
"watch:test": "npm run test -- --watch"
},
"engines": {
"node": ">= 10"
"node": ">= 14"
},
"dependencies": {
"azure-devops-node-api": "^11.0.1",
"chalk": "^2.4.2",
"cheerio": "^1.0.0-rc.9",
"commander": "^6.1.0",
"denodeify": "^1.2.1",
"glob": "^7.0.6",
"hosted-git-info": "^4.0.2",
"keytar": "^7.7.0",
Expand All @@ -60,18 +59,17 @@
},
"devDependencies": {
"@types/cheerio": "^0.22.29",
"@types/denodeify": "^1.2.31",
"@types/glob": "^7.1.1",
"@types/hosted-git-info": "^3.0.2",
"@types/lodash": "^4.14.123",
"@types/markdown-it": "0.0.2",
"@types/mime": "^1",
"@types/minimatch": "^3.0.3",
"@types/mocha": "^7.0.2",
"@types/node": "^10.17.60",
"@types/node": "^14.17.32",
"@types/read": "^0.0.28",
"@types/semver": "^6.0.0",
"@types/tmp": "^0.1.0",
"@types/tmp": "^0.2.2",
"@types/xml2js": "^0.4.4",
"@types/yauzl": "^2.9.2",
"husky": "^4.3.0",
Expand Down
4 changes: 1 addition & 3 deletions src/npm.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import * as path from 'path';
import * as fs from 'fs';
import * as denodeify from 'denodeify';
import * as cp from 'child_process';
import * as parseSemver from 'parse-semver';
import * as _ from 'lodash';
import { CancellationToken, log } from './util';

const stat = denodeify(fs.stat);
const exists = (file: string) =>
stat(file).then(
fs.promises.stat(file).then(
_ => true,
_ => false
);
Expand Down
Loading

0 comments on commit 302d33d

Please sign in to comment.