Make version requirements consistent between package and publish

[robertoaloi]

Hi! I tried to publish an extension with version 0.1.0-a. The version was accepted by the package command, but not by the publish:

$ vsce publish
ERROR  The version string '0.1.0-a' doesn't conform to the requirements for a version. It must be one to four numbers in the range 0 to 2147483647, with each number seperated by a period. It must contain at least one non-zero number.

Fair enough, then I replaced the -a with .0 (I need an extra value aside the semver and 0.1.0.0 should match the above expectations). This time is the package command which complains:

$ vsce package
ERROR  Invalid extension version '0.1.0.0'

If this is not supposed to be a valid version either, isn't the message returned by the publish command incorrect?

VSCE version: 1.73.0

[robertoaloi]

And now I notice that #415 is related. Also, there's a typo in the message itself:

seperated -> separated

[joaomoreno]

Yes, last month I had publish catch invalid versions, but there was a public outcry: #415 (comment)

So, closing it as designed.

[joaomoreno]

If this is not supposed to be a valid version either, isn't the message returned by the publish command incorrect?

Indeed. Let's just rewrite the message we get from the Marketplace.

[github-actions]

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀