Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration through config file or a vsce key under package.json #548

Closed
felipecrs opened this issue Mar 24, 2021 · 1 comment
Closed
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities released
Milestone

Comments

@felipecrs
Copy link
Contributor

Currently, the configuration can be done through CLI options, such as --yarn and --github-branch. It would be very good if configurations could be done through the package.json, as is for npm publish itself. Something like:

{
  "name": "vscode-shellcheck",
  [...]
  "vsce": {
    "yarn": true,
    "githubBranch": "main"
  }
}

This would be especially useful in semantic-release-vsce, as it currently does not allow the user to set extra arguments for the vsce call.

felipecrs/semantic-release-vsce#115

@joaomoreno joaomoreno added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Mar 25, 2021
@joaomoreno joaomoreno self-assigned this Nov 2, 2021
@joaomoreno joaomoreno added this to the November 2021 milestone Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

felipecrs added a commit to felipecrs/semantic-release-vsce that referenced this issue Jan 18, 2022
As `vsce` now supports configuration through the `package.json` file
(see microsoft/vscode-vsce#548), this option
was dropped to simplify the codebase. One should either rely on the
`vsce` automatically detecting when to use `yarn` (see
microsoft/vscode-vsce#480), or add the
following to `package.json`:

```json
{
    "vsce": {
        "yarn": true
    }
}
```
felipecrs added a commit to felipecrs/semantic-release-vsce that referenced this issue Jan 18, 2022
As `vsce` now supports configuration through the `package.json` file
(see microsoft/vscode-vsce#548), this option
was dropped to simplify the codebase. One should either rely on the
`vsce` automatically detecting when to use `yarn` (see
microsoft/vscode-vsce#480), or add the
following to `package.json`:

```json
{
    "vsce": {
        "yarn": true
    }
}
```
felipecrs added a commit to felipecrs/semantic-release-vsce that referenced this issue Jan 18, 2022
As `vsce` now supports configuration through the `package.json` file
(see microsoft/vscode-vsce#548), this option
was dropped to simplify the codebase. One should either rely on the
`vsce` automatically detecting when to use `yarn` (see
microsoft/vscode-vsce#480), or add the
following to `package.json`:

```json
{
    "vsce": {
        "yarn": true
    }
}
```
felipecrs added a commit to felipecrs/semantic-release-vsce that referenced this issue Jan 18, 2022
As `vsce` now supports configuration through the `package.json` file
(see microsoft/vscode-vsce#548), this option
was dropped to simplify the codebase. One should either rely on the
`vsce` automatically detecting when to use `yarn` (see
microsoft/vscode-vsce#480), or add the
following to `package.json`:

```json
{
    "vsce": {
        "yarn": true
    }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities released
Projects
None yet
Development

No branches or pull requests

2 participants