-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F5 doesn't work on Node <v8.0 #1
Comments
I can repro this issue when I do the following actions:
Though I'm not 100% sure, I guess it is because in this line: https://github.com/Microsoft/vscode-azurefunctions/blob/master/src/commands/createFunction.ts#L52, we just call method in FunctionsCli, so the .vscode setting folder is generated by the function CLI not by the extension, so the preLaunchTask is not get executed since there is no task.json at all. |
Our Node debugger will auto detect the protocol if you set |
@auchenberg when you say 'our' are you talking about 'VS Code'? This issue is not in VS Code (I've tried what you suggested), it's in the func cli. This url is not ready in time for VS Code to 'auto' detect the protocol: http://localhost:5858/json/version |
We call 'func host start', which is basically a black box that starts the node process for us |
@EricJizbaMSFT Yes I mean "our " as in "our VS Code debugger" in case you didn't know that we supported protocol detection. |
The error in your window says "No job functions found". You have to create a function before you F5 |
Ha, sorry, my bad |
Since creating this issue, Node 8.0+ has become the LTS release. We will no longer fix this issue. As a workaround for old versions of Node, users can manually remove |
Today we're hard-coding the debug protocol to be 'inspector' which only works on Node 8.0+.
Ideally we remove the protocol and VSCode auto-detects whether it needs to use "legacy" or "inspector" protocol - however that wasn't working for me on Node 8.0+
VSCode checks this url to detect the version
http://localhost:5858/json/version
. It's possible that url isn't up until afterJob host started
is printed.This could also be related (the func cli does not use the default 9229 port for debugging v8.0+): Azure/azure-functions-core-tools#261
The text was updated successfully, but these errors were encountered: