Update to the 0.0.13 release of the language server #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug with parameter hints and ARG variables in addition to adding documentation to ADD and COPY's --chown flag that was introduced in Docker CE 17.09. Signed-off-by: Remy Suen <remy.suen@gmail.com>
|
Here's a new Dockerfile to test the changes. I published a new release of the language server to include a fix for the bug mentioned mentioned here. FROM scratch
ARG ZOO_PORT
# $ZOO_PORT shouldn't be flagged as an error
EXPOSE $ZOO_PORT
# invoke Intellisense at the end,
# you should see documentation for the --chown flag
ADD --cho
COPY --cho
arg port
# you should see hover documentation over the chown flag
ADD --chown=root . .
COPY --chown=root . .
ENV a=b \
# pressing space in the next line's comment should not show parameter hints
# |
rcjsuen
changed the title
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
--chownflag forADDandCOPYwas finally published to the Docker website so I've extracted a small blurb from the documentation and added it to the language server.I also fixed a bug with parameter hints showing up in a comment that is embedded in a multiline instruction.
Please verify the behaviour with the following Dockerfile before and after upgrading. Thanks!