Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt version 0.0.18 of the language server #291

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Jul 3, 2018

I released a new release of my Dockerfile language server on Saturday. This release includes long-awaited fixes for the code completion error in #271 and the linting error related to private registries in #269, #280, and #288. As always, thank you to the vscode-docker community for your bug reports!

To test the new bug fixes and features of this release, please use the following four Dockerfiles to compare the behaviour of 0.0.17 and 0.0.18!

# see #271
# use ctrl+space at the end of this instruction and
# select one of the option, the code completion
# should insert the tag correctly
FROM microsoft/dotnet:2.1-

# these instructions that reference a private registry
# should have no linting errors
# see #269, #280, and #288
FROM example.registry.com:12345/base/image:1.0.0
FROM repository.mycompany:5000/tomcat:8.0
FROM my.private.repo.com:5000/some-image:latest
FROM host:5000/abc:9.0.0

# this is not a valid variable reference because
# ${bbb:x} does not have a valid modifier set
# for its variable substitution text
ARG bbb=value
ARG aaa=${bbb:x}

# this ARG has no name, it should be an error
ARG =value

# the parser should handle quotes in variable substitutions
ARG BUNDLE_WITHOUT
ENV BUNDLE_WITHOUT=${bundle_without:-'development test'}


# these two errors variables should cause errors
# due to quote parsing
ENV "a.b.c=xyz"
ENV "a.b.c=xyz
ARG image=scratch
# variables should be usable in FROMs and not
# cause any errors
FROM ${image:-alpine}
ARG ver=latest
FROM busybox:$ver
ARG ver
# hovering over $ver should show >> latest
RUN echo $ver
# this file should not have any errors
FROM scratch
ARG var=value \
# var2=value2

This update includes a few bug fixes as well as additional linting
checks.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@StephenWeatherford
Copy link
Contributor

@rcjsuen

This release includes long-awaited fixes for the code completion error in #271
I think you meant #277 here?

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Jul 5, 2018

Hi, @StephenWeatherford. You’re right. I meant #277. Sorry about that!

@StephenWeatherford StephenWeatherford requested a review from a team July 5, 2018 23:12
Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Remy!

@StephenWeatherford StephenWeatherford merged commit 4bc8403 into microsoft:master Jul 5, 2018
@rcjsuen rcjsuen deleted the lsp-0.0.18 branch July 6, 2018 00:19
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Jul 6, 2018

@StephenWeatherford Thanks for taking the time to review and merge it!

@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants