Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt version 0.0.19 of the language server #392

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Aug 22, 2018

I released version 0.0.19 of the language server this morning.

It includes:

As always, please use the following Dockerfile to test before and after behaviours!

# this is a
# long comment
# you can now fold this!

# try hitting F1
# and then typing >> Fold All Block Comments

# this is all gone!
# you don't need to read this
# fold and bye!
FROM node

# quoted multiline LABELs shouldn't be an error, see #338
LABEL "a"="b" \
    "c"="d" \
    "e"="f"

# quoted multiline ENVs shouldn't be an error, see #338
ENV "a"="b" \
    "c"="d" \
    "e"="f"

# EXPOSE should be capable of handling SCTP, new in Docker CE 18.03
EXPOSE 8080/sctp

# WORKDIR instructions that are not variables or are not absolute paths
# will now be a warning, toggle the setting below to change this
# docker.languageserver.diagnostics.instructionWorkdirRelative = "ignore" / "warning" / "error"
# defaults to "warning"
WORKDIR abc
WORKDIR $abc
WORKDIR /abc
WORKDIR C:\\abc

This release includes the following:
- validation fix for ENVs and LABELs
- validation warning for WORKDIRs that are not an absolute path
- folding support for comments
- adds support for SCTP in EXPOSEs, new in Docker CE 18.03

Signed-off-by: Remy Suen <remy.suen@raventelemetry.com>
@StephenWeatherford StephenWeatherford added this to the 0.2.0 milestone Aug 22, 2018
Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Remy!

@StephenWeatherford StephenWeatherford merged commit 513325a into microsoft:master Aug 29, 2018
@rcjsuen rcjsuen deleted the lsp-0.0.19 branch August 29, 2018 22:21
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Aug 29, 2018

Thank you for reviewing this, Stephen!

@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants