Ignore GOBIN whe go.toolsGopath is set #2339

microsoft · Mar 28, 2019 · 9f99c30 · 9f99c30
1 parent b597ae8
commit 9f99c30
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts
@@ -286,7 +286,13 @@ export function installTools(missing: string[], goVersion: SemVersion) {
 
 	// If the go.toolsGopath is set, use its value as the GOPATH for the "go get" child process.
 	// Else use the Current Gopath
-	let toolsGopath = getToolsGopath() || getCurrentGoPath();
+	let toolsGopath = getToolsGopath();
+	if (toolsGopath) {
+		// User has explicitly chosen to use toolsGopath, so ignore GOBIN
+		envForTools['GOBIN'] = '';
+	} else {
+		toolsGopath = getCurrentGoPath();
+	}
 	if (toolsGopath) {
 		const paths = toolsGopath.split(path.delimiter);
 		toolsGopath = paths[0];