Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

[suggestion/ask for help] Pop up before prepare data for go.import #1450

Closed
szyhf opened this issue Jan 10, 2018 · 2 comments
Closed

[suggestion/ask for help] Pop up before prepare data for go.import #1450

szyhf opened this issue Jan 10, 2018 · 2 comments
Milestone

Comments

@szyhf
Copy link

szyhf commented Jan 10, 2018

If there lots packages in GOPATH/src, while using go.import, the dialog for search always pop up after seconds delay. Then while waiting the dialog pop up, I always type the keyword I want to search in current editor, then the dialog show up.

That case lots of mistake type while focus on working.

I think its preparing data for search, but how about pop up as soon as press the hotkey of go.import, and user can type the keyword for search immediately while the background prepare the data for search.

I tried to fix it by myself but failed unless delete some of go packages.

Thanks a lot for helping 0.0

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 4, 2018

Thanks for reporting this @szyhf, good observation.

The fix is now out in the latest update to the Go extension (0.6.81)

The Go: Add Import feature will use the cached packages that get created by the auto-completion feature which also needs the packages. The only time it might still be slow is when used for the first time even before typing any code.

@ramya-rao-a ramya-rao-a added this to the 0.6.81 milestone Jun 4, 2018
@szyhf
Copy link
Author

szyhf commented Jun 5, 2018

Really happy to see that and thanks a lot ~

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants