Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

"useApiV1": false vs --api-version=2 #1876

Closed
gertcuykens opened this issue Aug 26, 2018 · 4 comments
Closed

"useApiV1": false vs --api-version=2 #1876

gertcuykens opened this issue Aug 26, 2018 · 4 comments

Comments

@gertcuykens
Copy link
Contributor

gertcuykens commented Aug 26, 2018

"useApiV1": false works great but what if someday we have a V3

Can we have a refactor that is consistent with the dlv cli flags --api-version=2 as in

"api-version":2 and the default is 1

Thanks

@lggomez
Copy link
Contributor

lggomez commented Sep 7, 2018

It is a reasonable request

The intended release plan of the delve V2 integration was to have this compatibility config flag during a couple of releases using V1 as the default, and then make the final switch to V2

@gertcuykens
Copy link
Contributor Author

gertcuykens commented Sep 7, 2018

If that's the case then it also fine, less config is better :) +1 for default V2 and removing the useApiV1 flag completly

@ramya-rao-a
Copy link
Contributor

I was meaning to set v2 as default for a while now, but was waiting to have an update which didnt have any other debug related changes, so that if there were any issues I could narrow it down to the version change.

Now is a good time, I'll make the change

@ramya-rao-a
Copy link
Contributor

In the latest update to this extension (0.6.90), we use v2 by default. useApiv1 is replaced with apiVersion

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants