-
Notifications
You must be signed in to change notification settings - Fork 646
Save All doesn't gofmt all files when "go:formatOnSave" flag is true #279
Comments
I looked into this, and it appears it isn't possible to fix this with the current VS Code APIs. This is primarily blocked on microsoft/vscode#239, which would make sure the formatting could be applied before the files are saved to disk. But it is more directly blocked by seemingly not being able to get a /cc @egamma and @bpasero in case they have a suggestion for how this could be handled with the current VS Code API. |
I think this needs microsoft/vscode#239 and is a good scenario for having that as API. |
It'd be nice to also have: edit: Looks like it exists, but no docs: |
The only catch is that there is a limitation on the time taken for the listeners of this event. |
Closing in favor of #540 which will fix this issue as well |
With the work in #540 completed, the latest update to the Go extension (0.6.70) has the fix for this issue. |
When I save a bunch of files all at once with Save All, only the active file is formatted, and the rest are saved in their un-fmt'ed state. (Autosave is off)
The text was updated successfully, but these errors were encountered: