This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
goBrowsePackages: toString bug fix + do not wait for goListAll #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marwan-at-work, |
ramya-rao-a
reviewed
Aug 17, 2017
src/goBrowsePackage.ts
Outdated
| showPackageFiles(selectedText); | ||
| } | ||
|
|
||
| function showPackageFiles(pkg: string) { |
There was a problem hiding this comment.
if pkg is empty string which can happen when the command is run without any editor open, then we will be needlessly creating a process to run go list
src/goBrowsePackage.ts
Outdated
| }); | ||
| } | ||
|
|
||
| function showTryAgainLater() { | ||
| // `go list all` has not completed. Wait for a second which is an acceptable duration of delay. |
There was a problem hiding this comment.
if at the end of this second, go list completes, we won't be showing anything. Was that intended?
There was a problem hiding this comment.
This is so that we don't get stuck in an infinite loop. And since we say try after sometime, it shouldn't be a surprise.
ramya-rao-a
approved these changes
Aug 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
An error in
goListAll()where we callchunks.toString(). The method puts,'s between every chunk which causes some lines to not be correct imports. I think this is why the auto-import on tab didn't work for all imports (at least for me)Refactored
goBrowsePackagesso that we don't have to wait forgoListAllto finish. This should speed up browsing packages a lot at initial time, especially for users with slower computers and very large GOPATH tree.In
goBrowsePackageswe still need a feature that depends ongoListAll(), which is to show a list of all the packages in your GOPATH to select from. So that logic is still there.