This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
bugfix: Ensure 'debug test' codelens only tests the selected test. #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have two functions `TestFoo` and `TestFooTwo`, and select 'debug test' on `TestFoo`, both tests will be executed. This happens because `go test -test.run` expects a regular expression, but we were only passing it a function name. Fixed by wrapping the function name in start/end markers.
|
@kegsay This fix is now available in the latest update (0.6.78) to the Go extension. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have two functions
TestFooandTestFooTwo, and select'debug test' on
TestFoo, both tests will be executed. This happensbecause
go test -test.runexpects a regular expression, but we wereonly passing it a function name, causing both tests to pass the regex check.
Fixed by wrapping the function name in start/end markers.
This is similar to what we do when running the tests e.g.
https://github.com/Microsoft/vscode-go/blob/3d35f45653506e14d4e98689eb22dd7fe4654478/src/testUtils.ts#L222