Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix smart package completion #1630

Merged
merged 1 commit into from
May 1, 2018
Merged

Fix smart package completion #1630

merged 1 commit into from
May 1, 2018

Conversation

uudashr
Copy link
Contributor

@uudashr uudashr commented Apr 17, 2018

Some people might want to test the main package with the existence of main.go.
On the _test.go file, it will suggest main as package name instead of publisher_test or publisher.

Dir structure example:

pubsub
- cmd
   - subscriber
      - main.go
   - publisher
      - main.go
      - main_test.go <-- package main
- doc.go
- pubsub.go

Q: Why not suggest main_test?
A: Main package are not going to be reused by others, all function might going to be non-exported. So the test package not will use the non _test pattern.

@uudashr uudashr closed this Apr 17, 2018
@uudashr uudashr reopened this Apr 17, 2018
@uudashr
Copy link
Contributor Author

uudashr commented Apr 17, 2018

@ramya-rao-a Should done, but still not sure why it's failed on tip version

@uudashr uudashr closed this May 1, 2018
@uudashr uudashr reopened this May 1, 2018
@uudashr uudashr changed the title Check main.go should take precedence over _test.go Fix smart package completion May 1, 2018
@ramya-rao-a ramya-rao-a merged commit 70bde3e into microsoft:master May 1, 2018
@ramya-rao-a
Copy link
Contributor

Thanks @uudashr! Sorry for the delay, work has been very busy

@ramya-rao-a
Copy link
Contributor

This change is now out in the latest update to the Go extension (0.6.79)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants