Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

doc(README) Fix the revive flags examples. #1703

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

wolfeidau
Copy link
Contributor

Road testing revive as a part of #1698 and found some small corrections required.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wolfeidau!
I'll have to update the code to support resolving of ~, ${workspaceRoot} and ${workspaceFolder when the config file path is passed using -config flag.
Currently this is supported for the --config flag which is used by gometalinter

@ramya-rao-a ramya-rao-a merged commit 5b6fa9f into microsoft:master Jun 1, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 1, 2018

Added support to resolve the file path passed in the -config flag to revive with d31636a

@wolfeidau Can you try using file paths that use ~ for home directory or ${workspaceRoot} ? You will need to download the latest vsix file again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants