Do not show blank identifiers in file outline

[ragurney]

Resolves #1889

[ragurney]

Needs a test, having trouble getting the test.go file to work.

[ramya-rao-a]

Thanks for the PR!

Since there is no immediate plans of having any other ignored symbols, lets skip using an array and compare the label directly with _

[ramya-rao-a]

About the test, are you able to run the existing tests?

[ragurney]

@ramya-rao-a I can run the existing tests, but four fail consistently each time:

  1) Go Extension Tests
base.js:240
       Test Definition Provider using gogetdoc:
     TypeError: Cannot read property 'uri' of null
      at vscode.workspace.openTextDocument.then.provider.provideDefinition.then.definitionInfo (/Users/rygurney/Code/personal/vscode-go/test/go.test.ts:92:33)
      at <anonymous>
  2) Go Extension Tests
base.js:240
       Test SignatureHelp Provider using gogetdoc:
     TypeError: Cannot read property 'signatures' of null
      at vscode.workspace.openTextDocument.then.testCases.map.provider.provideSignatureHelp.then.sigHelp (/Users/rygurney/Code/personal/vscode-go/test/go.test.ts:108:27)
      at <anonymous>
  3) Go Extension Tests
base.js:240
       Test Hover Provider using gogetdoc:
     TypeError: Cannot read property 'contents' of null
      at vscode.workspace.openTextDocument.then.testCases.map.provider.provideHover.then.res (/Users/rygurney/Code/personal/vscode-go/test/go.test.ts:141:80)
      at <anonymous>
  4) Go Extension Tests
base.js:240
       Gometalinter error checking:
      AssertionError [ERR_ASSERTION]: Failed to get linter results
      + expected - actual
      -false
      +true
      
      at util_1.getGoVersion.then.goCheck_1.check.then.diagnostics (/Users/rygurney/Code/personal/vscode-go/test/go.test.ts:404:12)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

When trying to add a line such as var _ string = "foo", I get two new failures as well, which I haven't had time to look into yet and address. I'll try to get to the bottom of this tonight!

[ramya-rao-a]

The gogetdoc related failures are because you don't have gogetdoc installed. Someone is working on updating the tests to not fail in such cases.

You can comment them and the gometalinter one while running your tests. Your changes are unrelated to them so you can safely ignore them.

When trying to add a line such as var _ string = "foo", I get two new failures as well,

That is mostly because there are other tests using the same file and now all the line numbers are changing. Try this

• In the fixtures table, create a new folder for outline and add a go file there as your test file. Update all the outline related tests to use this file

[msftclas]

All CLA requirements met.

[ramya-rao-a]

@ragurney If you merge from master branch now, you will not get those failures

[ragurney]

@ramya-rao-a sounds good, thanks! I think this PR is ready for another review.

[ramya-rao-a]

Looks great, Thanks!