Added completions for symbols from unimported pkg if there are multiple matches for pkg name

[shreyaskarnik]

Fixes #1884

[ramya-rao-a]

@shreyu86 With your change, after the user chooses from the completion list, they need to trigger completions one more time to get the symbols from the selected package.

I have pushed a commit to automatically trigger the suggestions.

Can you try it out and update the unit tests accordingly?

[shreyaskarnik]

Thanks, @ramya-rao-a I tested the new change. How do I go about updating the unit test? Can I hit tab on the first suggestion to trigger subsequent suggestion and then check for those?

[ramya-rao-a]

Or you can run the command acceptSelectedSuggestion using the vscode.commands.executeCommand function

[shreyaskarnik]

@ramya-rao-a I will update the tests and have this PR up for review soon, sorry I was out of office.

[ramya-rao-a]

No problem, take your time. I was out last week on vacation as well :)

[shreyaskarnik]

@ramya-rao-a I attempted to refactor the tests but was not successful in acceptSelectedSuggestion can you please provide some samples/pointers?

[ramya-rao-a]

Keep the existing test case as is and create a new one with the same sample test file

• After showTextDocument, set editor.selection to the right position where we want suggestions to be triggered
• Then use vscode.commands.executeCommand('editor.action.triggerSuggest') followed by vscode.commands.executeCommand('acceptSelectedSuggestion')
• Then check the document contents

Note: These are just ideas, I havent tried them out myself :)

[shreyaskarnik]

@ramya-rao-a I tried couple of options ^^ and I was not able to get the test refactored, can you please help?

[ramya-rao-a]

The problem is that the suggest widget is not completely rendered before the accept suggestion command is executed.

Never mind, I think we can skip that.

I pushed a commit for some extra checks in your test case. This is good to go. Just waiting for travis tests to pass

Thanks again!

[shreyaskarnik]

Thanks a lot for help on this! Really appreciate it.

[shreyaskarnik]

Thanks a lot @ramya-rao-a

[ramya-rao-a]

No problem at all