Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Better snippet #1980

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Better snippet #1980

merged 1 commit into from
Oct 10, 2018

Conversation

uudashr
Copy link
Contributor

@uudashr uudashr commented Oct 9, 2018

This should cover the iferr snippet for

  1. non-returning value
  2. return single value
  3. return 2 values
  4. return nil, err (by default)

@uudashr
Copy link
Contributor Author

uudashr commented Oct 9, 2018

Relate to #1962

@uudashr
Copy link
Contributor Author

uudashr commented Oct 10, 2018

@alecthomas might want to comment?

@alecthomas
Copy link
Contributor

LGTM 👍

ramya-rao-a
ramya-rao-a approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @alecthomas and @uudashr!

@ramya-rao-a ramya-rao-a merged commit 5c0a0d9 into microsoft:master Oct 10, 2018
@ramya-rao-a
Copy link
Contributor

@uudashr,
I hope that you have registered for the Microsoft Hacktoberfest

You definitely deserve the t-shirt for all your contributions to vscode-go :)

@pathcl
Copy link

pathcl commented Feb 15, 2019

hey all,

maybe Im doing something wrong? but its creating problems :(
screen shot 2019-02-15 at 20 01 50

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uudashr @alecthomas @ramya-rao-a @pathcl