Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Use LoggingDebugSession instead of vscode-debug-logger #2081

Merged
merged 1 commit into from
Dec 31, 2018
Merged

Use LoggingDebugSession instead of vscode-debug-logger #2081

merged 1 commit into from
Dec 31, 2018

Conversation

brycekahle
Copy link
Contributor

Fixes #858

ramya-rao-a
ramya-rao-a suggested changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to debug Go code with this change?
I am getting Debug adapter process has terminated unexpectedly (read error) error each time I try

@brycekahle
Copy link
Contributor Author

I'm pretty sure it worked for me, but I can try again.

@ramya-rao-a
Copy link
Contributor

Works fine on my Mac, I had issues on my Windows machine.
Will try again on Monday and get back to you

ramya-rao-a
ramya-rao-a approved these changes Dec 31, 2018
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now, my environment must have been messed up before.
Thanks!

@ramya-rao-a ramya-rao-a merged commit aa26bc6 into microsoft:master Dec 31, 2018
@ramya-rao-a ramya-rao-a mentioned this pull request Dec 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brycekahle @ramya-rao-a