Supoort attach/detach remote headless server without kill process #2125
Conversation
|
|
|
Thanks for the PR @BetaXOi! This is a very much needed feature. |
jhendrixMSFT
force-pushed
the
attach-detach
branch
from
7d1fc6b
to
3429ac1
Compare
|
Rebased on top of master. |
jhendrixMSFT
force-pushed
the
attach-detach
branch
from
3429ac1
to
26084e0
Compare
jhendrixMSFT
force-pushed
the
attach-detach
branch
from
df49556
to
ed7e86d
Compare
| debugConfiguration['useApiV1'] = dlvConfig['useApiV1']; | ||
| let useApiV1 = false; | ||
| if (debugConfiguration.hasOwnProperty('useApiV1')) { | ||
| useApiV1 = debugConfiguration['useApiV1'] === true; |
There was a problem hiding this comment.
nit: This and the line below can also be useApiV1 = !!debugConfiguration['useApiV1'].
|
@jhendrixMSFT @ramya-rao-a Any update on this PR? |
jhendrixMSFT
force-pushed
the
attach-detach
branch
from
fd242dd
to
21cf2cb
Compare
|
Sorry for the delay, been busy with Go SDK work. I've rebased on top of master. |
|
Why not merging this PR?? It's very perfect. |
|
@ramya-rao-a how do you want to proceed? |
|
What's the full goal of this PR? When will it be merged? |
|
Ramya and I discussed this earlier today, I'm going to make a few small changes. Should get merged later today/tomorrow. Sorry for the delay. |
Added template for attaching to process. Fixed template for connecting to a server. Removed unnecessary fields from AttachRequestArguments Cleaned up Delve.constructor to remove unnecessary parameters. Removed duplicated code from attachRequest(). Cleaned up handling of legacy 'useApiV1' setting. Ensure that property 'cwd' is set in debug configuration.
jhendrixMSFT
force-pushed
the
attach-detach
branch
from
cfa2eb7
to
5402218
Compare
Related: #1599 #1609
The reason is that sending
haltrequest twice when closedelvesession.This PR add support for
"request": "attach"inlaunch.json. You can attach a running process fromdlv --headlessremote server, and detach without kill the running process.I'm not a
TypeScriptbeginner even, so the code modified maybe ugly, but it works. It's wonderful if anyone improve the code.