Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

fix #2134 #2135

Merged
merged 1 commit into from
Nov 28, 2018
Merged

fix #2134 #2135

merged 1 commit into from
Nov 28, 2018

Conversation

oneslash
Copy link
Contributor

I am trying to fix #2134

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @oneslash!

Looks like this is your first PR in this project, Thanks & Welcome!

suggestions is never undefined as far as I know. It gets intialized to an empty array inside runGoCode

According to the call stack, the error is thrown at https://github.com/Microsoft/vscode-go/blob/0.7.0/src/goSuggest.ts#L163

It would be nice if we fix up getPackagePathFromLine to always return an array

@oneslash
Copy link
Contributor Author

I will fix it today

@oneslash
Copy link
Contributor Author

@ramya-rao-a, could you check now?

@oneslash
Copy link
Contributor Author

@ramya-rao-a, would be great if you can look into it soon :)

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oneslash Thanks for your patience. I was busy at work, so couldnt get to this PR sooner.

The current change looks good.

@ramya-rao-a ramya-rao-a merged commit eb60907 into microsoft:master Nov 28, 2018
@ramya-rao-a
Copy link
Contributor

Congratulations on getting your first PR in this repository merged!
Feel free to pick up any other issue with the help-wanted label. I appreciate all the help I can get :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'length' of undefined
2 participants