This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Close gocode daemon on deactivation #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Note that the extension doesn't actually start the gocode daemon, the gocode client itself does that as necessary. It is safe to close the daemon for the same reason however. If other clients were using the daemon, it will be restarted on their next request. Fixes #2132
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the extension doesn't actually start the gocode daemon,
the gocode client itself does that as necessary.
It is safe to close the daemon for the same reason however.
If other clients were using the daemon, it will be restarted
on their next request.
Fixes #2132