-
Notifications
You must be signed in to change notification settings - Fork 646
debug: Display nested content in the variables pane #2198
Conversation
Fixes #1010 |
If a variable contains children but they have not been loaded issue an expression command to delve to fetch them, then update the variable's children array with the result. This required refactoring the evaluateRequest method into two parts so that delve expressions can be evaluated synchronously. Removed unreferenced param in convertDebugVariableToProtocolVariable.
@ramya-rao-a FYI |
@jhendrixMSFT Great job! I have 2 main concerns here
|
@ramya-rao-a are the requests in parallel? My intention was to perform them synchronously. Good point on the spurious evaluations on strings, I will update |
Log error if evaluation fails.
Its not just when the variable itself is a string. This also applies to array of strings, numbers or any of the primitive types. These would not need further evaluations. |
I found a great description of when to load children here. Will update based on this spec. |
Include a map's length in the output.
If a variable contains children but they have not been loaded issue an
expression command to delve to fetch them, then update the variable's
children array with the result. This required refactoring the
evaluateRequest method into two parts so that delve expressions can be
evaluated synchronously.
Removed unreferenced param in convertDebugVariableToProtocolVariable.