Add module definitions for test fixtures #2306
Conversation
|
Aside from fixtures that contain incomplete code on purpose (completions) the ones that contain working code like diffTestData may be split into individual modules (as they are separate programs) |
| @@ -0,0 +1 @@ | |||
| module github.com/microsoft/vscode-go/gofixtures/basetest | |||
There was a problem hiding this comment.
Does this assume that the user has cloned the vscode-go repo under github.com/microsoft or that doesn't matter?
Sorry, my module knowledge is not up to date :(
There was a problem hiding this comment.
Don't worry, I've struggled myself with this lately (we don't use 1.11 at work yet)
As long as they're not dependencies it doesn't matter which path they have, I believe
There was a problem hiding this comment.
Thanks @lggomez
@jhendrixMSFT That is your understanding as well, right?
There was a problem hiding this comment.
Sorry for the delay. This is correct, since nobody will be importing these packages the value is solely used as the identity.
No description provided.