Added showGlobalVariables as a workspace level parameter #2351
Conversation
…n package.json and also updated goDebugConfiguration.ts to parse the new showGlobalVariables
|
|
package.json
Outdated
| @@ -1233,7 +1238,8 @@ | |||
| "maxVariableRecurse": 1, | |||
| "maxStringLen": 64, | |||
| "maxArrayValues": 64, | |||
| "maxStructFields": -1 | |||
| "maxStructFields": -1, | |||
| "showGlobalVariables": false | |||
There was a problem hiding this comment.
I believe we need to pull showGlobalVariables one level up.
The properties in LoadConfig is a 1:1 to what is at https://github.com/go-delve/delve/blob/4c9a72e486f1f0d0c90ecede8415a871dced8117/service/api/conversions.go#L276
|
@ramya-rao-a updated |
aschade92
force-pushed
the
workspace-show-global-vars
branch
from
ca45fe4
to
a8c252e
Compare
…e-show-global-vars
aschade92
force-pushed
the
workspace-show-global-vars
branch
from
a8c252e
to
f2f002c
Compare
|
@jhendrixMSFT FYI, I am changing the default value for |
|
@aschade92 Looks like this is your first PR contribution to this project, Thanks & Welcome! I have pushed 2 more commits. 1 to update the description and default value for the |
|
@ramya-rao-a sounds good, thanks for reviewing! |
Before, this option was only available in
launch.jsonbut this PR makesshowGlobalVariablesas a workspace level setting so that things like the debug and run test actions can use this setting.