This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add command to restart language server #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @SteelPhase! Apologies for not getting to this sooner. There is one small issue of the restarted server not being added to the subscriptions that keep the list of disposables in the extension. I have made the relevant changes in the PR, didnt get time to test it though. |
|
I will test it tomorrow, and post here with an update. |
|
@ramya-rao-a it appears to be working as I'd expect. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems pretty straight forward, and does actually work. I would ask that this included for the time being in some form. Please let me know what you thing of this. I originally thought about adding some logging around it, but I didn't spot any example code on how to do just that.
This should resolve #2500