Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add command to restart language server #2530

Merged
merged 4 commits into from
Jun 4, 2019

Conversation

SteelPhase
Copy link
Contributor

This seems pretty straight forward, and does actually work. I would ask that this included for the time being in some form. Please let me know what you thing of this. I originally thought about adding some logging around it, but I didn't spot any example code on how to do just that.

This should resolve #2500

@ramya-rao-a
Copy link
Contributor

Thanks for the PR @SteelPhase! Apologies for not getting to this sooner.

There is one small issue of the restarted server not being added to the subscriptions that keep the list of disposables in the extension.

I have made the relevant changes in the PR, didnt get time to test it though.
Can you give it a try and let me know how it goes?

@SteelPhase
Copy link
Contributor Author

I will test it tomorrow, and post here with an update.

@SteelPhase
Copy link
Contributor Author

@ramya-rao-a it appears to be working as I'd expect.

@ramya-rao-a ramya-rao-a merged commit 94c8dd8 into microsoft:master Jun 4, 2019
@SteelPhase SteelPhase deleted the langserver-restart branch June 4, 2019 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[features request] Add a command to restart language server just like restart a typescript language server
2 participants