-
Notifications
You must be signed in to change notification settings - Fork 646
Conversation
Hi @sijad, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Thanks @sijad. I remember running into that same issue when I took a look at this awhile ago. In theory - we could filter the results to only those in the current file - but it would be hugely wasteful to compute all these lint results and just throw them away. I think that issue may be a blocker for getting |
@lukehoban I'm about to create a experimental version of gometalinter in TypeScript |
@sijad I think it might be better to stick with using gometalinter if possible - I prefer to keep as much Go-specific logic in well-maintained Go ecosystem projects instead of moving it into the Per the comment on alecthomas/gometalinter#119 it sounds like other tools that use gometalinter do just deal with just invoking linters at folder level. I'm open to trying the same in |
Sorry for delay, with some changes now 1- I'll add a few test case for |
Thanks @sijad. This generally looks good. Keeping I'm not sure whether there is sufficient test infrastructure currently to add a test for this, but if so, would be great to add that. It will likely require at least adding installation of |
Ok some test cases also has been added, @lukehoban let me know if anything need to be changed |
not sure why it fails in travis mac environment, any thoughts? |
Wondering what is the status of this. I have played around with this a little bit as well. https://github.com/JohanSJA/vscode-go/tree/gometalinter |
Is there a reason this hasn't been merged? I would really like this feature. Could I help in any way? |
Finally got a chance to review and merge. I had to tweak the regexp a little to match some For others interested in this - note that it's still not the default - and if you want to use |
Thanks @sijad for the PR! |
@sijad The latest
@sijad @lukehoban Was there any reason, not to install gometalinter and then run I have a PR out #735 to do the same, and was wondering if I am missing some reason why it shouldnt be done. Would love your feedback on the PR as well. |
ran into this
not sure what should I do