This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
debug: fix 'run without debugging' #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug 1: when generating the default debug configuration because there is no user-configured one, the extension dropped noDebug field and caused the program to run with debugging enabled. Fix it (goDebugConfiguration.ts) Bug 2: when debug adapter receives noDebug request, it runs the program with `go run` instead of invoking the program through dlv. The `go run` will not work in modules mode if the command runs outside the main module. Set cwd accordingly. Fixes microsoft#3121 TESTED=manually with the example attached in microsoft#3121
ramya-rao-a
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1: when generating the default debug configuration
because there is no user-configured one, the extension
dropped noDebug field and caused the program to run with
debugging enabled. Fix it (goDebugConfiguration.ts)
Bug 2: when debug adapter receives noDebug request, it
runs the program with
go runinstead of invoking theprogram through dlv. The
go runwill not work in modulesmode if the command runs outside the main module. Set
cwd accordingly.
Fixes #3121
TESTED=manually with the example attached in #3121