Fixes #310 - install Missing Analysis Tool. Better feedback would be nice

[benclarkwood]

This commit causes goInstallTools to log very differently than present.

Presently, goInstallTools just writes the output of stdout and stderr to the Go outputChannel.

This commit proposes logging much less in the case of success, and only logging the cause of errors.

Let me know what you think @lukehoban.

(A total success)

Installing 9 missing tools
  gorename
  gopkgs
  gocode
  goreturns
  godef
  golint
  go-outline
  go-symbols
  guru

Installing gopkgs SUCCEEDED
Installing go-outline SUCCEEDED
Installing go-symbols SUCCEEDED
Installing godef SUCCEEDED
Installing gorename SUCCEEDED
Installing golint SUCCEEDED
Installing goreturns SUCCEEDED
Installing gocode SUCCEEDED
Installing guru SUCCEEDED

All tools successfully installed. You're ready to Go :).

(A failure)

Installing 9 missing tools
  gorename
  gopkgs
  gocode
  goreturns
  godef
  golint
  go-outline
  go-symbols
  guru

Installing go-outline FAILED
Installing gorename FAILED
Installing gopkgs FAILED
Installing go-symbols FAILED
Installing golint FAILED
Installing goreturns FAILED
Installing gocode FAILED
Installing godef FAILED
Installing guru FAILED

9 tools failed to install.

gorename:
Error: Command failed: go get -u -v golang.org/x/tools/cmd/gorename
Fetching https://golang.org/x/tools/cmd/gorename?go-get=1
https fetch failed: Get https://golang.org/x/tools/cmd/gorename?go-get=1: dial tcp: lookup golang.org: no such host
golang.org/x/tools (download)
# cd /Users/ben/Documents/gowork/src/golang.org/x/tools; git pull --ff-only
fatal: unable to access 'https://go.googlesource.com/tools/': Could not resolve host: go.googlesource.com
package golang.org/x/tools/cmd/gorename: exit status 1
Fetching https://golang.org/x/tools/cmd/gorename?go-get=1
https fetch failed: Get https://golang.org/x/tools/cmd/gorename?go-get=1: dial tcp: lookup golang.org: no such host
golang.org/x/tools (download)
# cd /Users/ben/Documents/gowork/src/golang.org/x/tools; git pull --ff-only
fatal: unable to access 'https://go.googlesource.com/tools/': Could not resolve host: go.googlesource.com
package golang.org/x/tools/cmd/gorename: exit status 1

NOTE: Didn't include every failure's output as they're all the same (no internet connection).

[msftclas]

Hi @benclarkwood, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[msftclas]

@benclarkwood, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

[lukehoban]

One thing I was meaning to look into/change was running these serially instead of in parallel. I'm pretty sure go get has issues when multiple gets are run in parallel, and users have reported that the existing extension occasionally runs into errors. Since you are making changes here - may make sense to also just change this to do the gets serially?

[lukehoban]

This looks great - big improvement! Left a few comments on the code changes.

[lukehoban]

I've merged this along with a few additional improvements that address the issues I mentioned in review and fixed a few additional related issues. Thanks again!