Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix for when Go is used from source without release tag #549

Merged
merged 3 commits into from
Oct 26, 2016

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Oct 23, 2016

Fixes #545

  • Moved getGoVersion, SemVersion and isVendorSupported from goInstallTools.ts to util.ts
  • check for GO15VENDOREXPERIMENT env var is added for Go 1.6 because

Go 1.5 introduced experimental support for vendoring, enabled by setting the GO15VENDOREXPERIMENT environment variable to 1. Go 1.6 keeps the vendoring support, no longer considered experimental, and enables it by default. It can be disabled explicitly by setting the GO15VENDOREXPERIMENT environment variable to 0. Go 1.7 will remove support for the environment variable.

  • If no release tag is found and GO15VENDOREXPERIMENT is explicitly set to 0, isVendorSupported will return false.
  • If no release tag is found and GO15VENDOREXPERIMENT is not explicitly set to 0, isVendorSupported will return true.
  • If release tag is not found, golint and gotests would be installed assuming that the Go version supports them. If not, then error messages from running these tools will bubble up to the user

@ramya-rao-a ramya-rao-a merged commit c35b419 into microsoft:master Oct 26, 2016
@ramya-rao-a ramya-rao-a deleted the fix-version branch April 9, 2017 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants