This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
pkg suggestions to appear after gocode suggestions #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Nov 4, 2016
| @@ -184,6 +184,8 @@ export class GoCompletionItemProvider implements vscode.CompletionItemProvider { | |||
| } | |||
| item.insertText = suggest.name + '(' + paramSnippets.join(', ') + ') {{}}'; | |||
| } | |||
| // Add same sortText to all suggestions from gocode so that they appear before the unimported packages | |||
There was a problem hiding this comment.
Will they still be in the right order within the 'a' and 'z' groups, or should it be like 'a' + item.name?
There was a problem hiding this comment.
@roblourens The completion items are sorted first by the sortText and then by Label. So we are good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since we introduced importable packages as suggestions in the auto-complete, people have found it annoying that these package suggestions are interspersed among variables/function names etc.
Excerpt from Gitter:
This PR is to group all the package suggestions and make them appear AFTER the usual/normal suggestions from
gocode.