-
Notifications
You must be signed in to change notification settings - Fork 646
added go.inferGopath. Similar to GoSublime's use_gs_gopath #762
Conversation
Hi @codmajik, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
Hi @codmajik, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@codmajik Thanks for the PR! A few notes: Take a case where the user has set
Also, can you write a unit test for this as well? You will have to change |
@ramya-rao-a Thanks for your feedback. The case you provided is the actual use case for this and also the current implementation in GoSublime. Where |
@codmajik I am assuming that when you say "global config", you mean the "User settings" in VS Code. All configurations defined in the By the time you fetch the settings by Therefore, in our case here both Thinking more on this, it makes sense for the inferred path to win when both |
@ramya-rao-a Thanks. I made those changes on my local checkout. I know it is not needed but I can create a new pull request with that as improvements. I just need to figure out how to test this with your current test suite. btw |
@codmajik Never mind the tests, I was thinking of doing a major refactoring in the unit test area soon, I can take care of that. What changes are you referring to exactly? |
@ramya-rao-a, changes to make sure that if PS: should I delete the branch? |
@codmajik I think its fine the way it is. You can delete your branch. I have updated the descriptions for both There is command Not very important, but you can give that a try. |
I would like to propose this implementation for the feature request raised in #757