Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fixed line endings for scripts/terminateProcess.sh #838

Closed
wants to merge 1 commit into from
Closed

Fixed line endings for scripts/terminateProcess.sh #838

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2017

Since the file has Windows line endings bash/sh cannot execute the file under Linux which is illogical since it is only ran under Linux (/Mac). Changed the endings from CRLF to LF now the debugger works again fine

see #834 and #438

@msftclas
Copy link

msftclas commented Mar 3, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@roblourens
Copy link
Member

Are you sure you didn't just check out CRLF line endings? They are LF on my machine

@ghost
Copy link
Author

ghost commented Mar 3, 2017

Hi,
Yes you are right the git source uses LF.

Though the extension that you install from the extension explorer of vscode appearently uses a version which uses Windows endings. The pull request is from my ~/.vscode/extensions and that one used CRLF which is also why so many people did have this problem. Just update that one and everything will work.

@ghost ghost closed this Mar 3, 2017
@ghost ghost deleted the linux-terminateProcess branch March 3, 2017 22:49
@roblourens
Copy link
Member

@FASA123 I see it now, yeah it was published with CRLF endings. But when I fix that locally, it actually still reproes for me...

@kisPocok
Copy link

kisPocok commented Mar 3, 2017

I've also fixed the CRLF ending locally but the bug still there.

ps.: Cloned this repo (current master branch) then with launch extension works normally.

@roblourens
Copy link
Member

Actually, it wasn't working when I just resaved the file with LF, but I deleted and recreated it with LF, and now it works. That's weird. Also, doing the opposite (running out of sources, changing LF to CRLF) broke it in the same way. So I think this is likely the problem.

@kisPocok
Copy link

kisPocok commented Mar 3, 2017

The current master version works for me. No errors so far.

@roblourens
Copy link
Member

@FASA123 Did you also have to chmod +x terminateProcess.sh?

@roblourens
Copy link
Member

To make this work I have to chmod +x, and fix the line endings. When I publish an extension with a .sh from Mac, it comes out with the x flag automatically. Apparently that's not the case from Windows, so maybe we just have to always publish from mac/linux?

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 3, 2017

Just published from a Mac

@kisPocok @FASA123 @YCF Can you get the latest version (0.6.55) and confirm if things work for you?

@kisPocok
Copy link

kisPocok commented Mar 4, 2017

Eureka, it works! 👍

@YCF
Copy link

YCF commented Mar 4, 2017

@ramya-rao-a
It works well!

@ramya-rao-a
Copy link
Contributor

woohoo!

@ghost
Copy link
Author

ghost commented Mar 4, 2017

Yes I did have to chmod as well.
And yes the extension works now.

@roblourens
Copy link
Member

Great! Thanks for pointing out the line ending issue.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants