-
Notifications
You must be signed in to change notification settings - Fork 646
Fixed line endings for scripts/terminateProcess.sh #838
Conversation
…ws) to LF (linux)
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Are you sure you didn't just check out CRLF line endings? They are LF on my machine |
Hi, Though the extension that you install from the extension explorer of vscode appearently uses a version which uses Windows endings. The pull request is from my ~/.vscode/extensions and that one used CRLF which is also why so many people did have this problem. Just update that one and everything will work. |
@FASA123 I see it now, yeah it was published with CRLF endings. But when I fix that locally, it actually still reproes for me... |
I've also fixed the CRLF ending locally but the bug still there. ps.: Cloned this repo (current master branch) then with launch extension works normally. |
Actually, it wasn't working when I just resaved the file with LF, but I deleted and recreated it with LF, and now it works. That's weird. Also, doing the opposite (running out of sources, changing LF to CRLF) broke it in the same way. So I think this is likely the problem. |
The current master version works for me. No errors so far. |
@FASA123 Did you also have to |
To make this work I have to chmod +x, and fix the line endings. When I publish an extension with a .sh from Mac, it comes out with the x flag automatically. Apparently that's not the case from Windows, so maybe we just have to always publish from mac/linux? |
Eureka, it works! 👍 |
@ramya-rao-a |
woohoo! |
Yes I did have to chmod as well. |
Great! Thanks for pointing out the line ending issue. |
Since the file has Windows line endings bash/sh cannot execute the file under Linux which is illogical since it is only ran under Linux (/Mac). Changed the endings from CRLF to LF now the debugger works again fine
see #834 and #438