Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @DisplayName support for JUnit 5 #446

Closed
jdneo opened this issue Nov 23, 2018 · 3 comments · Fixed by #481
Closed

Add @DisplayName support for JUnit 5 #446

jdneo opened this issue Nov 23, 2018 · 3 comments · Fixed by #481
Milestone

Comments

@jdneo
Copy link
Member

jdneo commented Nov 23, 2018

From @smoyer64 in #93 (comment):

After running a few more JUnit5 tests through VS Code's Java test extension I've also realized that the @DisplayName annotations are not being used when present. I can submit a separate issue for this problem if you want (along with a small code sample and Eclipse output.

@jdneo jdneo mentioned this issue Nov 23, 2018
@jdneo
Copy link
Member Author

jdneo commented Nov 23, 2018

Thanks for @BaerMitUmlaut contributes the support in #357

Another potential work is that we might also need to show the display name in the test report. @smoyer64 any idea for this?

@jdneo jdneo modified the milestones: 0.12.0, 0.11.1 Nov 23, 2018
@smoyer64
Copy link

@jdneo ... I was on vacation but wanted to (after the fact) let you know that it looks good to me!

@jdneo
Copy link
Member Author

jdneo commented Dec 1, 2018

@smoyer64 Thanks. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants