Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for #region in javascript code #48154

Closed
fab1o opened this issue Apr 18, 2018 · 2 comments
Closed

Improve support for #region in javascript code #48154

fab1o opened this issue Apr 18, 2018 · 2 comments
Assignees
Labels
editor-autoindent Editor auto indentation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@fab1o
Copy link

fab1o commented Apr 18, 2018

Support for #region is buggy. It only works for the first region but the second region cannot be folded.

  • VSCode Version: 1.23.0-insider
  • OS Version: Both Windows 10 and macOS High Sierra

Steps to Reproduce:

  1. Create a new javascript file
  2. Copy and paste the code below
class Testing {
    // #region prop
    get prop() {
        return 0;
    }
    set prop(p) {}
    // #endregion

    // #region prop2
    get prop2() {
        return 0;
    }
    set prop2(p) {}
    // #endregion
}

Result:
capture

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Apr 18, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added editor editor-autoindent Editor auto indentation issues labels Apr 18, 2018
@mjbvz mjbvz self-assigned this Apr 18, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 18, 2018

Same root cause as microsoft/TypeScript#23270

@mjbvz mjbvz closed this as completed Apr 18, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-autoindent Editor auto indentation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants