-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node modules are looked up in global paths #68024
Comments
Some of the errors thrown
|
Re-installed vscode and extensions appear to be working again. But this did break extensions on my old install |
I've got the same problem with the latest vscode. I just share it again. At first
Repeated for several plugins.
SIGABRT
|
@ModernWebService @tkhwang Does this reproduce if you disable all extensions? (Most likely you have an extension installed that is causing this). You can also look for the extension host log to see which extension was being loaded when the crash occured. ( With this stable release, we have updated our Electron version and if you are using any extension that uses native node modules, it will stop working and could cause extension host crashes. |
@alexandrudima , As I checked, the crash dosn't occur after uninstalling the following plugin as you said. VS Code for Node.js - Development Pack You may reproduce after installing this plugin, I guess. (update) Actually the above plugin consists of a lot of plugins. As I tested, the crash dosn't occur after installing each of them. The crash only occurs after installing the the plugin itself. (update2) I found another plugin which crashes. Settings Sync
|
Tried reinstall trough brew, didn't help. Text version:
```
[Extension Host] debugger listening on port 29729
extensionHost.ts:231 Extension Host
extensionHost.ts:232 Debugger listening on ws://127.0.0.1:29729/cdf2c22a-577b-4491-b25a-e85569d055d4
For help, see: https://nodejs.org/en/docs/inspector
extensionHost.ts:231 Extension Host dyld: Symbol not found: __ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorENS_14SideEffectTypeE log.ts:161 INFO no standard startup: not a new window extensionHost.ts:231 Extension Host dyld: Symbol not found: __ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorENS_14SideEffectTypeE extensionService.ts:457 Extension host terminated unexpectedly. Code: null Signal: SIGABRT
|
I was having problems with the |
My extensions broke too. Most of them. Like Project Manager and other important for me. Seems that they don't work on a new version of vscode. Not cool. Edit: 👆 👆 👆 |
For me I went straight to re-installing VSCode fresh and seems to have cleaned out whatever was causing my issue. I still have the same extensions as before I believe, since I have it setup for laravel Node and some Go development. However, my dev tools were throwing similar errors as screenshot above. It seems like it may have broke something that these plugins were listening on, was in the middle of deploying a long project when this happened so I did not have time to mess around with dissecting what the root cause was. |
The cause is that node.js called by a VSCode extension host process tries to load modules in I think VSCode should clear some entries of module.paths on extension host processes to prevent this behavior. To workaround this issue, I recommend moving |
For now, I just downloaded v1.32 version and disabled updates in
{
"extensions.autoUpdate": false,
"update.channel": "none"
} |
thanks, disabled the |
I'm the author of Settings Sync. Users has been reporting about extension host killed by Settings Sync. We removed the chokidar dependency from Its only broken On Mac, but works on Windows and Linux. My main concern is: @alexandrudima whats your views about it? |
@shanalikhan, see my comment #68024 (comment). |
Here is a easier repro for the global paths:
Observe how 3 global lookup folders are present (the last 3):
With my proposed change, this gets reduced to:
|
I had an update notification pop up which I did not realize it was going to run when I closed my editor and then re-opened it shortly after. Since the latest released up, all my extensions will not run and on start up i get "Extension host terminated unexpectedly."
No matter how many times I click restart extension host it continues showing the failed message.
To clarify when this happened to me I was using 1.30 and restarted VSCode got the prompt for the January Changes skimmed it and then started noticing that no plugins were working.
Since the re-install I do believe all my extensions are working as expect and do not believe I removed any. Most of my extensions are Larave, PHP, 1 or 2 Python, couple RoR, and then some Node/angular.
The text was updated successfully, but these errors were encountered: