Add NTLM support #43
Merged
Add NTLM support #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,14 +147,45 @@ export class HttpClient implements ifm.IHttpClient { | |||
| } | |||
|
|
|||
| request(protocol: any, options: any, objs: any, onResult: (err: any, res: http.ClientResponse, contents: string) => void): void { | |||
| // Set up a callback to pass off 401s to an authentication handler that can deal with it | |||
| let self = this; | |||
There was a problem hiding this comment.
you can avoid this if you use a fat-arrow function in the callback below:
var callback = (err, res, contents) => {
// replace self with this
});`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Pending code scan of node-http-ntlm; already in progress.)
Add an NTLM handler using portions of the node-http-ntlm package. Caller provides username and password (and optional domain and workstation) to create the handler. Added two methods to IRequestHandler to determine if the handler can handle the particular type of authentication (e.g., NTLM). I considered adding a new interface but it ended up making the code where the RequestHandler is used more complex (WebApi.ts) so I went the simpler route.
Updated node.d.ts with file from DefinitelyTyped (the ntlm support required the AgentOptions interface exposed by node). Note that the version of Node.js (0.10.1) remains the same.
Took a dependency on underscore, received OSS approval and added ThirdPartyNotices.txt.
Updated Copyright line in LICENSE file per guidance from legal.
Regression tested on Ubuntu VM with xplat build agent. Created a build definition that ran an Ant build and uploaded JAR files as artifacts. Configuration of the build agent and builds on the build definition succeeded.
Manually testing the NTLM changes with the VS Code extension (currently in progress).