-
Notifications
You must be signed in to change notification settings - Fork 451
Non-English version of the TF Executable #192
Comments
Yes, there is an issue with non-english language, but you can use this workaround or look at this thread in order to solve your issue. Basically, you have to rename the localization folder for your language in order to force TF.exe to be in english... |
Not sure that applies in this case. I don't have anything installed other than English. |
HI @pwaller24, thanks for trying out the extension. I'd be interested in seeing the output (as much as you can show) from this command (from a command prompt): Also, I'd be really interested in confirming that you saw the same error with the TEE CLC (tf.cmd). We explicitly set an environment variable to force it to return English strings (something that tf.exe is missing). |
Here you go @jeffyoung: C:>"C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\TF.exe" workfold "C:\TFS\P2 Portfolio\Oil and Gas Accounting\Enterprise Upstream\EU\Main" ============================================================================================================================================================= I ran it with the fully qualified path to TF.exe. |
Thanks @pwaller24. I'm glad I'm not a betting man (or I would have lost). I certainly can't tell why you would get the error about the non-ENU tf.exe. I do see that you're using https and I currently have a bug where the extension cannot connect using NTLM over HTTPS (#59). However, I've added some additional logging to the attached private drop of the extension. I'd appreciate it if you could install it, turn on debug logging and provide the results. Hopefully the log will shed some light on the problem. So in order to install this private drop, you need to uninstall the current extension and then side-load this VSIX. After downloading the ZIP file, you'll need to rename it by dropping the .ZIP extension. Then, after selecting the But back to the HTTPS issue, what version of TFS are you connecting to? |
Here is the log file from making those changes. |
Thanks for the quick turnaround! For whatever reason, we're having trouble parsing the results of our "GetVersion" command. All that does is parse the results of And thanks for confirming your version of TFS. |
Happy to help get this sorted out! Here are the results: C:\Program Files (x86)\Microsoft Visual Studio 14.0>"C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\TF.EXE" add -noprompt -? Adds new files and folders from a local file system location to Team Foundation tf vc add [itemspec] [/lock:(none|checkin|checkout)] [/encoding:filetype] |
Thanks. I've attached yet another private build here. The line that contains the version value looks good. The regex we use finds the version in the string that's there just fine at regex101. But we still don't find it. Maybe logs from this particular private build will show the truth. |
Ok, gave that a try and here is the log: |
😮 OK. Can you tell me what version of Visual Studio you're using? I see in the command line (which we should be parsing successfully) this version value: I'm going to see if I can find the same version and debug this. (For the record, the reason we error out with that message is because we figured we couldn't parse the version out of that command line. But we figured that would only happen in a couple of cases. Looking at the output you provided, I don't see a reason why it should fail especially since the regex pulls it out just ine.) |
Thanks @pwaller24. I added a bit more logging and beefed up the regex a bit (to fix a scenario that could fail it). Could you try this one and provide the results (please delete the existing team-extension.log before re-running). (I'm pulling my hair out over this! 😄) |
Thanks for looking into it.... |
OK. It appears that the version of TF.exe you're using is writing more to stdout than we ever expected. 😄 It took a while but I've now got what I believe to be the changes we need to properly parse the version string out of stdout. (I've also used your output, without any PII, as inputs into a new unit test for our version parsing code.) Here's what should be the last one (fingers crossed). |
I think that's got it! No message this time. |
Great, thanks for confirming! I submitted a PR with the fix. A couple of other things though. First, your server is configured for HTTPS which I have an issue tracking support for (#59). Since you're using TFS 2017, I may have a different solution there. Also, I see that the version of TF.exe you're using apparently doesn't support the 'xml' value for the format option of the status command ( |
My version of VS is from MSDN. Would that be the difference? Thanks for getting it fixed. I'll look for an update on the HTTPS issue. |
Well, after digging through this for most of the day, this is apparently what happened. Our TFVC support requires the ability to output 'xml' from the status command (and likely others) so we can parse it in a consistent way. The initial VS 2015 Update 3 shipped with a version of tf.exe that doesn't have this support. (We developed the feature using a version of tf.exe from VS 2015 that did have the support and went ahead and just assumed all 14.0.0-based versions of tf.exe had that support. That wasn't correct but we didn't know it to be true.) VS 2015 U3 shipped with a version of tf.exe close to what you have ( I've got a PR out (#199) that will detect a version lower than 14.102 and provide a button to click that takes you to that CSR page with download instructions. And even though you might have a version of the CSR already installed (as it looks like you already do), you can re-install it with the download link and get a later version with additional updates to ensure you have the latest fixes. (And I think @MindGirl may have run into this issue once before in #179). I'll get this PR into the next release of the extension soon. Thanks again @pwaller24. |
I am getting this message when I update the VS Code settings with the full path to the TF executable. I have VS 2015 Enterprise installed. It is the version from my MSDN subscription. Attempting to use the latest version of the TEE tf.cmd does not work as well.
The text was updated successfully, but these errors were encountered: