This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Miscellaneous fix-ups #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpricket
reviewed
May 2, 2017
src/tfvc/commands/undo.ts
Outdated
| @@ -53,27 +53,27 @@ export class Undo implements ITfvcCommand<string[]> { | |||
| // * All of the files have no pending changes (exitCode === 100) | |||
| //If some of the files have no pending changes, we want to process the ones that did. | |||
| //If all of the files have no pending changes, return [] | |||
| //Otherwise, we assume some error occurred so let that be thrown. | |||
| //Otherwise, we assume some error occurred so const that be thrown. | |||
There was a problem hiding this comment.
I think you mean "let" here and on the comment below
jpricket
reviewed
May 2, 2017
src/tfvc/tfcommandlinerunner.ts
Outdated
| @@ -250,7 +250,7 @@ export class TfCommandLineRunner { | |||
| let stdout: string = buffers.join(""); | |||
| if (isExe) { | |||
| // TF.exe repeats the command line as part of the standard out when using the @ response file options | |||
| // So, we look for the noprompt option to let us know where that line is so we can strip it off | |||
| // So, we look for the noprompt option to const us know where that line is so we can strip it off | |||
jpricket
approved these changes
May 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.