Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Skeleton menu items #97

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Skeleton menu items #97

merged 1 commit into from
Feb 10, 2017

Conversation

jeffyoung
Copy link
Contributor

Including a menu item to show the TFVC output window. This PR will make it easier for us to contribute to the menus.

image

image

image

Including a menu item to show the TFVC output winow
Copy link
Contributor

@davidstaheli davidstaheli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested changes to menu item text. But are these troublesome because menu item text has to match command text?

Signin -> Sign In...
Signout -> Sign Out
Create Work Item -> Create Work Item...

@jeffyoung
Copy link
Contributor Author

Sorry, I should have mentioned it. Signin, Signout, and Create Work Item actually won't be in the those menu items. They're there (for now) as placeholders to demonstrate how we can get different menu items in the different areas of the menu. Sorry for that. But, basically, as we move forward, we can now put menu items where they need to go and hook them up with commands. I wanted to get this in so Jason had an easier time adding commands as well.

Copy link
Member

@jpricket jpricket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffyoung jeffyoung merged commit 1fca2f6 into master Feb 10, 2017
@jeffyoung jeffyoung deleted the jeyou/skeleton-menus branch February 10, 2017 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants