Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid let syntax on 0.7 #67

Open
JobJob opened this issue Sep 27, 2017 · 1 comment
Open

Invalid let syntax on 0.7 #67

JobJob opened this issue Sep 27, 2017 · 1 comment

Comments

@JobJob
Copy link

JobJob commented Sep 27, 2017

On today's julia 0.7, using Lazy throws the error:

The form `Expr(:let, ex, binds...)` is deprecated. Use `Expr(:let, Expr(:block, binds...), ex)` instead.
ERROR: LoadError: LoadError: syntax: invalid let syntax
Stacktrace:
 [1] include_relative(::Module, ::String) at ./loading.jl:526
 [2] include at ./sysimg.jl:14 [inlined]
 [3] include(::String) at /Users/job/.julia/v0.7/Lazy/src/Lazy.jl:3
 [4] include_relative(::Module, ::String) at ./loading.jl:526
 [5] include(::Module, ::String) at ./sysimg.jl:14
 [6] anonymous at ./<missing>:2
in expression starting at /Users/job/.julia/v0.7/Lazy/src/liblazy.jl:149
in expression starting at /Users/job/.julia/v0.7/Lazy/src/Lazy.jl:105
ERROR: Failed to precompile Lazy to /Users/job/.julia/lib/v0.7/Lazy.ji.

Changing these lines to ex = Expr(:let, Expr(:block, bindings...), body) fixes it for 0.7, but breaks it for 0.6

No time to get a PR working for all versions right now (plus there are probably other places to change), but thought I'd post here so someone can run with it.

@micahjsmith
Copy link

Does anybody have plans to fix this 0.7 compat issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants