Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-44: Cancel not propagated on C# Dev Kit Test Explorer #44

Open
MikeSchulze opened this issue Feb 24, 2024 · 0 comments
Open

GD-44: Cancel not propagated on C# Dev Kit Test Explorer #44

MikeSchulze opened this issue Feb 24, 2024 · 0 comments
Assignees
Labels
bug Something isn't working gdunit4.test.adapter This issue is related to `gdunit4.test.adapter` help wanted Extra attention is needed
Milestone

Comments

@MikeSchulze
Copy link
Owner

The used GdUnit4 version:
GdUnit4Mono 4.2.1

The used Godot version:
Godot 4.2.1

OS including version:
Windows 11

Describe the bug
Using the gdunit4.test.adapter in Visual Studio Code and C# Dev Kit.
When running the tests from the "Test Explorer" the cancel do not kill the child Godot process.

microsoft/vscode-dotnettools#947

Steps to Reproduce

  • Open the TEST EXPLORER
  • Select GdUnit4.Tests.Asserts and press run
  • Wait until tests ar started and press the cancel button on the test explorer
    The test looks like are canceld
    image
========== Starting test run ==========
Start executing tests, 131 TestCases total.
Run tests -------->
stdout: Godot Engine v4.2.1.stable.mono.official.b09f793f5 - https://godotengine.org
stdout: Vulkan API 1.3.260 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 4070 Ti
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\AssertionsTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\BoolAssertTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\DictionaryAssertTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\EnumerableAssertTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\NumberAssertTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\ObjectAssertTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\SignalAssertTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\StringAssertTest.cs
stdout: Load testsuite D:\development\workspace\gdUnit4Mono\test\src\asserts\Vector2AssertTest.cs
========== Test run aborted: 19 Tests (19 Passed, 0 Failed, 0 Skipped) run in < 1 ms ==========

But the Godot test runner process is still running until all tests are finished.

@MikeSchulze MikeSchulze added bug Something isn't working help wanted Extra attention is needed labels Feb 24, 2024
@MikeSchulze MikeSchulze self-assigned this Feb 24, 2024
@MikeSchulze MikeSchulze changed the title C# Dev Kit Test Explorer cancel not propagated to gdunit4.test.adapter GD-44: gdunit4.test.adapter cancel not propagated on C# Dev Kit Test Explorer Feb 25, 2024
@MikeSchulze MikeSchulze added this to the v4.3.0 milestone Feb 25, 2024
@MikeSchulze MikeSchulze added the gdunit4.test.adapter This issue is related to `gdunit4.test.adapter` label Feb 28, 2024
@MikeSchulze MikeSchulze changed the title GD-44: gdunit4.test.adapter cancel not propagated on C# Dev Kit Test Explorer GD-44: Cancel not propagated on C# Dev Kit Test Explorer Feb 28, 2024
@MikeSchulze MikeSchulze modified the milestones: 4.3.0, 4.4.0 Jul 30, 2024
@MikeSchulze MikeSchulze modified the milestones: 4.4.0, 4.4.x Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gdunit4.test.adapter This issue is related to `gdunit4.test.adapter` help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant