Add target and change update handlers api #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
johnhaley81
reviewed
Mar 24, 2020
| /> | ||
| ``` | ||
|
|
||
| The value of the field is exposed via `form.input` record. For extra safety, we disable all inputs during form submission using `form.submitting` property which is of boolean type. The next 2 functions are very important: | ||
| 1. `form.blurEmail: unit => unit`: must be triggered from `onBlur` handler of an input field | ||
| 2. `form.updateEmail: (input => input) => unit`: must be triggered from `onChange` handler of an input field. It takes a function as an argument which takes the current form `input` and must return updated `input` record. | ||
| 1. `form.blurEmail: ReactEvent.Focus.t => unit`: must be triggered from `onBlur` handler of an input field |
There was a problem hiding this comment.
This type signature is much better! The intended use is encoded in the function type sig instead of a unit => unit
johnhaley81
reviewed
Mar 24, 2020
| ``` | ||
|
|
||
| This runtime error happens due to [React's `SyntheticEvent` being pooled](https://reactjs.org/docs/events.html#event-pooling). Since callback gets triggered asynchronously, by the time it gets called, the event is already null'ed by React. | ||
| 1. `form.blurEmail: unit => unit` |
There was a problem hiding this comment.
I'm not 100% sure on what we'd get back for a blur event in React Native. CC @endlo
There was a problem hiding this comment.
Considering that in react native api there are event-less handlers exist, we shouldn't encode events in formality handlers b/c it would restrict usage only to RN handlers with events which is unnecessary limitation imo.
|
If @endlo doesn't have anything to add then this looks gtg to me |
|
Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
/cc @johnhaley81